Doc debian 10 updates #11488

robje · 2020-04-26T11:57:30Z

Some (Debian specific) updates to the Debian 10 installation procedure.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Have you followed our code guidelines?
If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

There are ways to install debian without the acl package. Add it to the required list

Debian does not require systemd. This makes calling systemctl to restart processes a problem. The more generic way in Debian is to call service

In Debian webservers are configured using -available and -enabled directories. Make better use of this stucture.

Instead of overwriting snmpd.conf inform Debian of the change. Because snmpd.conf contains sensitive info make it only user accessible

SourceDoctor · 2020-04-26T12:17:54Z

some questions:

changing from nano to editor? why?
chmod on /etc/snmp/snmpd.conf why?
what do you want to do with dpkg-divert --rename /etc/snmp/snmpd.conf
nginx configuration -> as i know it's a *.conf not a *.vhost
why remove this line: rm /etc/nginx/sites-available/default && rm /etc/nginx/sites-enabled/default

robje · 2020-04-26T14:46:47Z

some questions:

apparently I need more git school. I thought I answered most of these questions in the commit messages. Apparently my additional lines went missing.

* changing from nano to editor? why?

Debian has the command editor which is the users preferred editor. It can be nano or emacs or vim or something different.
Using editor here also better indicates the user is free to chose an editor.

* chmod on /etc/snmp/snmpd.conf  why?

snmpd.conf holds (can hold) sensitive information like community stings and passwords.
This is why the file by default is mode 600 on installation. The chmod is to restore this after copying the librenms version.

* what do you want to do with dpkg-divert --rename /etc/snmp/snmpd.conf

This is to let the package manager know this file is now managed in an other way than through the package manager.
It results in less user interaction on upgrades.

* nginx configuration -> as i know it's a *.conf not a *.vhost

This was not changed. The file was called *.vhost already. And it works as the include is *

include /etc/nginx/sites-enabled/*;

* why remove this line: rm /etc/nginx/sites-available/default && rm /etc/nginx/sites-enabled/default

This line is not removed.
I've updated it to remove the sites-enabled file only. That way the package manager can still manage the sites-available version.

SourceDoctor · 2020-04-26T16:44:14Z

changing editor from nano to editor
may be good, but i would it keep on nano, or change it to editor on all debian/ubuntu system documentations, but this should be a separate PR

snmpd chmod
if you do it, you have to be ensure file is owned bei snmpd process.
So a chown with user and group is missing

dpkg-divert
not exists on any documentations i've ever seen, also not here.
To avoid user confusion i would keep it away

SourceDoctor · 2020-05-03T11:08:44Z

@robje something new about it?

murrant · 2020-05-08T04:40:24Z

@robje maybe a note about editor. So people don't get stuck in vim ;D

Also, this needs merging with upstream.

SourceDoctor · 2020-06-06T10:05:04Z

something new here?

…c-debian-10-updates

robje · 2020-06-06T16:05:46Z

@robje maybe a note about editor. So people don't get stuck in vim ;D

AFAIK nano is the default editor in Debian, no worries about getting stuck in vim unless one really wants to :)

Also, this needs merging with upstream.

done

robje · 2020-06-06T16:10:21Z

changing editor from nano to editor
may be good, but i would it keep on nano, or change it to editor on all debian/ubuntu system documentations, but this should be a separate PR

agreed

snmpd chmod
if you do it, you have to be ensure file is owned bei snmpd process.
So a chown with user and group is missing

snmpd.conf is read before dropping privileges. On a new installation it is owned by root.

dpkg-divert
not exists on any documentations i've ever seen, also not here.
To avoid user confusion i would keep it away

Will put this forward in a separate pull request

SourceDoctor · 2020-06-06T16:35:52Z

doc/Installation/Installation-Debian-10-Nginx.md

 ```

 # Configure snmpd

 ```bash
 cp /opt/librenms/snmpd.conf.example /etc/snmp/snmpd.conf
+chmod 600 /etc/snmp/snmpd.conf


you change mod to 600 ... doesn't work if snmpd.conf is not owned by snmpd user

if you limit access such high a chown is also needed

It is not. snmpd is started as root and privileges are dropped after starting. snmpd must be started as root to acquire privileged port 161.

snmpd.conf is read as root, before dropping privileges.

SourceDoctor

LGTM

murrant · 2020-07-03T04:43:46Z

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-65-release-changelog-june-2020/12687/1

murrant · 2020-07-03T04:44:45Z

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-65-release-changelog-june-2020/12687/1

robje added 6 commits April 26, 2020 11:14

add package acl to required list

debf679

There are ways to install debian without the acl package. Add it to the required list

replace systemctl with more generic service

7d3d68d

Debian does not require systemd. This makes calling systemctl to restart processes a problem. The more generic way in Debian is to call service

rm command allows multiple parameters

6f4a860

use nginx config in a more Debian way

7b815e7

In Debian webservers are configured using -available and -enabled directories. Make better use of this stucture.

better snmpd.conf handling

4c11ae4

Instead of overwriting snmpd.conf inform Debian of the change. Because snmpd.conf contains sensitive info make it only user accessible

replace nano with users preferred editor

f304da6

SourceDoctor added the Documentation 📖 label Apr 26, 2020

SourceDoctor added the User-Pending Currently waiting for user response label Apr 26, 2020

SourceDoctor closed this Jun 6, 2020

SourceDoctor reopened this Jun 6, 2020

robje added 2 commits June 6, 2020 18:00

Merge branch 'master' of https://github.com/librenms/librenms into do…

47efdc1

…c-debian-10-updates

revert back to nano as editor

97c96e3

remove dpkg-divert as per PR discussion

e85e3d3

SourceDoctor reviewed Jun 6, 2020

View reviewed changes

SourceDoctor self-requested a review June 6, 2020 16:43

SourceDoctor removed the User-Pending Currently waiting for user response label Jun 6, 2020

SourceDoctor approved these changes Jun 6, 2020

View reviewed changes

SourceDoctor merged commit f590e63 into librenms:master Jun 6, 2020

robje deleted the doc-debian-10-updates branch June 6, 2020 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doc debian 10 updates #11488

Doc debian 10 updates #11488

robje commented Apr 26, 2020

SourceDoctor commented Apr 26, 2020

robje commented Apr 26, 2020

SourceDoctor commented Apr 26, 2020 •

edited

SourceDoctor commented May 3, 2020

murrant commented May 8, 2020

SourceDoctor commented Jun 6, 2020

robje commented Jun 6, 2020

robje commented Jun 6, 2020

SourceDoctor Jun 6, 2020

SourceDoctor Jun 6, 2020 •

edited

robje Jun 6, 2020

SourceDoctor left a comment

murrant commented Jul 3, 2020

murrant commented Jul 3, 2020

Doc debian 10 updates #11488

Doc debian 10 updates #11488

Conversation

robje commented Apr 26, 2020

Please note

Testers

SourceDoctor commented Apr 26, 2020

robje commented Apr 26, 2020

SourceDoctor commented Apr 26, 2020 • edited

SourceDoctor commented May 3, 2020

murrant commented May 8, 2020

SourceDoctor commented Jun 6, 2020

robje commented Jun 6, 2020

robje commented Jun 6, 2020

SourceDoctor Jun 6, 2020

Choose a reason for hiding this comment

SourceDoctor Jun 6, 2020 • edited

Choose a reason for hiding this comment

robje Jun 6, 2020

Choose a reason for hiding this comment

SourceDoctor left a comment

Choose a reason for hiding this comment

murrant commented Jul 3, 2020

murrant commented Jul 3, 2020

SourceDoctor commented Apr 26, 2020 •

edited

SourceDoctor Jun 6, 2020 •

edited